-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChatMessage & ChatFeed edit functionality #7559
Open
ahuang11
wants to merge
8
commits into
main
Choose a base branch
from
add_edit_message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7559 +/- ##
===========================================
+ Coverage 71.90% 82.24% +10.33%
===========================================
Files 338 339 +1
Lines 51441 51575 +134
===========================================
+ Hits 36990 42418 +5428
+ Misses 14451 9157 -5294 ☔ View full report in Codecov by Sentry. |
ahuang11
commented
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5761
Useful for editing & re-triggering downstream chat events if necessary
Introduces:
enter_pressed
inChatAreaInput
because it's better than watchingvalue
change and parallelsTextInput
'senter_pressed
show_edit_icon
for the new edit icon that toggles the ChatMessage between original object &ChatAreaInput
; only shows if message is from useredited
for when an edit is submitted in ChatMessageedited
event; if so, calledit_callback
withcontents, index, instance
edit.mp4